Open
Conversation
nhsd-angel-pastor
force-pushed
the
feature/CCM-15019_dl_events_to_reporting
branch
8 times, most recently
from
6bf9123 to
9d9fc50
Compare
nhsd-angel-pastor
force-pushed
the
feature/CCM-15019_dl_events_to_reporting
branch
9 times, most recently
from
cfd84c1 to
b17ad8b
Compare
| - data | ||
| dataschemaversion: | ||
| type: string | ||
| const: "1.0.0" |
Contributor
Author
There was a problem hiding this comment.
Restricted the DL events to be this version
nhsd-angel-pastor
force-pushed
the
feature/CCM-15019_dl_events_to_reporting
branch
from
b17ad8b to
ce359ea
Compare
| pattern: ^/nhs/england/notify/(production|staging|development|uat)/(primary|secondary|dev-[0-9]+)/(data-plane|control-plane)/digitalletters/eventbus | ||
| minLength: 40 | ||
| pattern: ^/nhs/england/notify/(production|staging|development|uat)/(primary|secondary|dev-[0-9]+)/digitalletters/eventbus | ||
| minLength: 30 |
Contributor
Author
There was a problem hiding this comment.
Subtracted 10 as it's the length of "data-plane"
nhsd-angel-pastor
force-pushed
the
feature/CCM-15019_dl_events_to_reporting
branch
from
ce359ea to
8c7545a
Compare
nhsd-angel-pastor
force-pushed
the
feature/CCM-15019_dl_events_to_reporting
branch
from
8c7545a to
af50392
Compare
nhsd-angel-pastor
force-pushed
the
feature/CCM-15019_dl_events_to_reporting
branch
from
af50392 to
1997736
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modified Digital Letters events profile for the fields:
** Note the changes in NHS Notify Standards https://github.com/NHSDigital/nhs-notify-standards/pull/24/changes
** datacontenttype
** dataschema
** dataschemaversion
** These are reflected in NHS Notify Standards https://github.com/NHSDigital/nhs-notify-standards/pull/25/changes and
Updated the code and tests to populate the fields source, plance, datacontenttype, dataschema and dataschemaversion as they are now required.
Added terraform code to create a rule to match the events with plane data and the target to be the eventpub lambda.
See comment for the test evidence
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.